Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify wiremock config in oidc #35749

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

manofthepeace
Copy link
Contributor

@manofthepeace manofthepeace commented Sep 5, 2023

In wiremock 3, ResponseTemplateTransformer should not be created manually; see wiremock/wiremock#2350 (comment)

Wiremock now creates one internally, by default local. Also made few simplifications within the same class by using static imports + bump to 3.0.3 while at it.

follows up on #35649

supersedes #35820
supersedes #35821

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform area/testing labels Sep 5, 2023
@manofthepeace manofthepeace changed the title Simplicy wiremock config in oidc Simplify wiremock config in oidc Sep 5, 2023
@sberyozkin sberyozkin self-requested a review September 5, 2023 14:51
@sberyozkin
Copy link
Member

Thanks, though now that I think about it, may be it is better to have 2 commits in this PR, one bump the version, another update the OIDC test code. Guillaume, do you have any preferences ?

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Sep 6, 2023

Thanks, though now that I think about it, may be it is better to have 2 commits in this PR, one bump the version, another update the OIDC test code. Guillaume, do you have any preferences ?

Yeah, that's probably best

@manofthepeace
Copy link
Contributor Author

Done

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 9, 2023

Failing Jobs - Building 26e0e8e

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 20 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 20 #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppDefaults line 64 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectJBangTest.testCreateCliDefaults line 127 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 98 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@sberyozkin
Copy link
Member

The test failures are not related

@sberyozkin sberyozkin merged commit 482501b into quarkusio:main Sep 9, 2023
48 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 9, 2023
@manofthepeace manofthepeace deleted the wm3_simplification branch October 3, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants